[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG276a95bdf27c: [clangd] Decouple preambleworker from astworker, NFCI (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/ https:/

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet updated this revision to Diff 254516. kadircet added a comment. - Start preambleworker in sync mode instead of blocking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/ https://reviews.llvm.org/D76125 Files: clang-tools-extra/cl

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet updated this revision to Diff 251021. kadircet added a comment. - Reset CurrentReq inside run loop, rather than inside build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/ https://reviews.llvm.org/D76125 Files: clang-tools-ex

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet updated this revision to Diff 251011. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/ https://reviews.llvm.org/D76125 Files: clang-tools-ex

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet marked 16 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:265 + /// Updates the TUStatus and emits it. Only called in the worker thread. + void emitTUStatus(TUAction Action, +const TUStat

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:412 RanASTCallback = false; -emitTUStatus({TUAction::BuildingPreamble, TaskName}); log("ASTWorker

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

sammccall added a comment. In D76125#1926773 , @sammccall wrote: > I think the only real outstanding thing is TUStatus, which we're still > discussing offline. Since this patch is intended to be NFC, I see two paths > consistent with the spirit of that

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

sammccall added a comment. This basically looks good, just nits (mostly about comments, sorry I can't help myself). I think the only real outstanding thing is TUStatus, which we're still discussing offline. Since this patch is intended to be NFC, I see two paths consistent with the spirit of t

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet marked 16 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:218 +PreambleRequested.wait(Lock, [this] { return PreambleReq || Done; }); +// No request means we are done. +if (!PreambleReq)

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet updated this revision to Diff 250705. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/ https://reviews.llvm.org/D76125 Files: clang-tools-ex

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:155 namespace { +/// Responsible for building and providing access to the preamble of a TU. This +/// worker doesn't guarantee that each preamble request will be built, in case

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. First step to enable deferred preamble builds. Not intending to land it alone, will have f