[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

2020-03-17 Thread Richard Sandiford via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc47f971694be: [Sema][SVE] Don't allow sizeless objects to be thrown (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76088/new/ htt

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

2020-03-12 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76088/new/ https://reviews.llvm.org/D76088 ___

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

2020-03-12 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added a comment. In D76088#1920241 , @efriedma wrote: > We already have a special case for void* here; it's trivial to extend that to > also check for sizeless types. I don't want to add weird semantic > restrictions just to save a few chara

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

2020-03-12 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm updated this revision to Diff 250066. rsandifo-arm added a comment. Allow pointers to sizeless types to be thrown. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76088/new/ https://reviews.llvm.org/D76088 Files: clang/include/clang/B

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

2020-03-12 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. We already have a special case for void* here; it's trivial to extend that to also check for sizeless types. I don't want to add weird semantic restrictions just to save a few characters in the compiler. I agree that most people won't run into it either way. Reposito

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

2020-03-12 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added a comment. In D76088#1920070 , @efriedma wrote: > Why is throwing an `svint8_t *` an error? I don't see any obvious reason to > forbid that. Yeah, I agree there's no obvious reason why it wouldn't work. The same reasoning applies h

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

2020-03-12 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Why is throwing an `svint8_t *` an error? I don't see any obvious reason to forbid that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76088/new/ https://reviews.llvm.org/D76088 ___

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

2020-03-12 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a project: clang. The same rules for throwing and catching incomplete types also apply to sizeless types. This pat