Re: [PATCH] D7606: Fix adress cast for C++ in SEMA

2016-01-06 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 44124. sfantao added a comment. Rebase. http://reviews.llvm.org/D7606 Files: lib/Sema/Sema.cpp lib/Sema/SemaCast.cpp test/CodeGen/address-space-explicit-cast.c Index: test/CodeGen/address-space-explicit-cast.c

Re: [PATCH] D7606: Fix adress cast for C++ in SEMA

2015-12-02 Thread Samuel Antao via cfe-commits
sfantao added a comment. Any more comments on this patch? Thanks! Samuel http://reviews.llvm.org/D7606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D7606: Fix adress cast for C++ in SEMA

2015-12-02 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 41676. sfantao added a comment. - Rebase. http://reviews.llvm.org/D7606 Files: lib/Sema/Sema.cpp lib/Sema/SemaCast.cpp test/CodeGen/address-space-explicit-cast.c Index: test/CodeGen/address-space-explicit-cast.c ==

Re: [PATCH] D7606: Fix adress cast for C++ in SEMA

2015-11-18 Thread Samuel Antao via cfe-commits
sfantao added a comment. Ping! http://reviews.llvm.org/D7606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D7606: Fix adress cast for C++ in SEMA

2015-11-06 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 39619. sfantao added a comment. Rebase and add check to make sure the pointee of the pointers being casted match. In a previous review, it was suggested by Richard Smith to move the check to the end of `TryReinterpretCast`. However, that does not solve the