[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

AlexanderLanin added a comment. Fine for me. Fixes newline bug in https://bugs.llvm.org/show_bug.cgi?id=45150. However I don't have "review privileges" here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 updated this revision to Diff 250053. njames93 marked 6 inline comments as done. njames93 added a comment. - Extend tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037 Files: clang-tools-extra/

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 added inline comments. Comment at: clang/lib/Tooling/ReplacementsYaml.cpp:22 +static constexpr Escapes EscapeChars[] = { +{'\n', 'n'}, {'\r', 'r'}, {'\t', 't'}, {'\\', '\\'}}; + AlexanderLanin wrote: > Just so I have asked ;-) > Escaping every \ woul

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 updated this revision to Diff 250038. njames93 added a comment. - Fix another broken dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037 Files: clang-tools-extra/clang-apply-replacements/C

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

AlexanderLanin requested changes to this revision. AlexanderLanin added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Tooling/ReplacementsYaml.cpp:22 +static constexpr Escapes EscapeChars[] = { +{'\n', 'n'}, {'\r', 'r'}, {'\t', 't'}, {'

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 updated this revision to Diff 249875. njames93 added a comment. - Fix broken dependencies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037 Files: clang-tools-extra/clang-apply-replacements/CMakeLi

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/unittests/Tooling/ReplacementsYamlTest.cpp:68 + ASSERT_EQ(Doc.Replacements.size(), NewDoc.Replacements.size()); + if (Doc.Replacements.size() == NewDoc.Replacements.size()) { +for (

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 updated this revision to Diff 249860. njames93 added a comment. - Fix test case not being ran Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037 Files: clang/include/clang/Tooling/ReplacementsYaml.h

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 updated this revision to Diff 249857. njames93 added a comment. - Small tidy of code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037 Files: clang/include/clang/Tooling/ReplacementsYaml.h clang/

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 updated this revision to Diff 249856. njames93 added a comment. Herald added a subscriber: mgorny. - Moved escape/unescape impl to source file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76037/new/ https://reviews.llvm.org/D76037 Files:

[PATCH] D76037: [clang] tooling replacements are escaped when exporting to YAML

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, AlexanderLanin. Herald added a project: clang. Herald added a subscriber: cfe-commits. Escapes replacement text when exporting to yaml and unescapes when importing from yaml. Repository: rG LLVM Github Monore