[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0da09498394: [Hexagon] Add support for Linux/Musl ABI (part 2) (authored by sidneym). Changed prior to commit: https://reviews.llvm.org/D75638?vs=252950&id=253000#toc Repository: rG LLVM Github Mono

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

sidneym updated this revision to Diff 252950. sidneym added a comment. update for new tidy checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75638/new/ https://reviews.llvm.org/D75638 Files: clang/include/clang/Basic/TargetInfo.h clang/lib

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

kparzysz added a comment. I'm not sure if it's worth defining these macros especially if this is the only place where they are used. We'd need a more coordinated effort to replace all 32's with named constants where it refers to a register size, and I'm not even sure if we could classify wheth

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

bcain added a comment. In D75638#1917565 , @bcain wrote: > @kparzysz do you have any thoughts about those review comments? @sidneym is this just pulling existing contents downstream to go upstream? If so let's expedite this please Repository: rG LL

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

bcain added a comment. @kparzysz do you have any thoughts about those review comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75638/new/ https://reviews.llvm.org/D75638 ___ cfe-commits mailing l

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

bcain added a comment. In general, I recommend qualifying metric and threshold values with their associated units: bits, bytes, pages, etc. That way it's easy to see where the unit conversions are happening and easy to see whether the logic is correct without reasoning about how the value chan

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

sidneym created this revision. sidneym added reviewers: kparzysz, bcain, adasgupt. Herald added a project: clang. Herald added a subscriber: cfe-commits. The clang driver updates needed to support Hexagon's Linux ABI. This builds on what was added by https://reviews.llvm.org/rG7fee4fed4c75c13d0c