[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

This revision was automatically updated to reflect the committed changes. Closed by commit rG33bb32bbc674: [Sema] Reword -Wrange-loop-analysis warning messages (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75613/new/ http

[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75613/new/ https://reviews.llvm.org/D75613

[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

aaronpuchert updated this revision to Diff 248332. aaronpuchert added a comment. Drop SpelledAsLValue = false, which seems to be wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75613/new/ https://reviews.llvm.org/D75613 Files: clang/include

[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

aaronpuchert updated this revision to Diff 248325. aaronpuchert added a comment. - Change diagnostic names to reflect the changed messages. - Also change the wording of note_use_type_or_non_reference. - The warning that was warn_for_range_const_reference_copy is only emitted if the operator* call

[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

Mordante added a comment. Thanks for the patch! I've some minor nits, but other then that it looks fine. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2427 "selected '%select{begin|end}0' %select{function|template }1%2 with iterator type %3">; def warn_for_r

[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

aaronpuchert added a comment. This addresses my earlier comment D73007#1853563 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75613/new/ https://reviews.llvm.org/D75613 _

[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, Mordante, rtrieu. Herald added a project: clang. Herald added a subscriber: cfe-commits. aaronpuchert added a comment. This addresses my earlier comment D73007#1853563 . The