This revision was automatically updated to reflect the committed changes.
Closed by commit rG29a4239d31c6: [Sema] Fix a crash when attaching comments to
an implicit decl (authored by erik.pilkington).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
jkorous accepted this revision.
jkorous added a comment.
This revision is now accepted and ready to land.
Thanks a bunch for fixing this!
That also means we can skip all the implicit declarations from the `for (const
Decl *D : Decls) {` just a couple lines below your fix since implicit
declarat
erik.pilkington created this revision.
erik.pilkington added a reviewer: jkorous.
Herald added subscribers: ributzka, dexonsmith.
When an implicitly generated decl was the first entry in the group, we
attempted to lookup comments with an empty FileID, leading to crashes. Avoid
this by trying to
