This revision was automatically updated to reflect the committed changes.
Closed by commit rG7d2fdd3f6639: [clang-format] parse C# object initialisers
(authored by Jonathan Coe ).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75473/
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Thank you!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75473/new/
https://reviews.llvm.org/D75473
___
cfe-commits mailing list
cfe
jbcoe updated this revision to Diff 248039.
jbcoe added a comment.
Remove code without test coverage.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75473/new/
https://reviews.llvm.org/D75473
Files:
clang/lib/Format/UnwrappedLineParser.cpp
clang/unittests/Format/FormatTestCSharp.cpp
jbcoe marked an inline comment as done.
jbcoe added inline comments.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1978
+ if (FormatTok->is(tok::l_paren))
+parseParens();
+
krasimir wrote:
> I don't understand why this is needed, and removing
krasimir added inline comments.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1978
+ if (FormatTok->is(tok::l_paren))
+parseParens();
+
I don't understand why this is needed, and removing this `if` does not cause
any tests to fail.
Please add
jbcoe created this revision.
jbcoe added a reviewer: krasimir.
jbcoe added a project: clang-format.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Treat C# object initializers as braced lists.
Allow lambdas inside C# braced lists.
Repository:
rG LLVM Github Monorepo
h