[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG27a3ecee4558: [clang][Modules] Add -fsystem-module flag (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75395/new/ https://reviews.ll

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75395/new/ https://reviews.llvm.org/D75395 ___ c

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

Bigcheese updated this revision to Diff 247755. Bigcheese added a comment. Cleaned up the test to not reference unused paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75395/new/ https://reviews.llvm.org/D75395 Files: clang/include/clang/Dri

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

dexonsmith added a comment. In D75395#1901859 , @Bigcheese wrote: > In D75395#1901778 , @dexonsmith > wrote: > > > > This is used when > > > converting an implicit build to an explicit build to match the > > > sy

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

Bigcheese added a comment. In D75395#1901778 , @dexonsmith wrote: > > This is used when > > converting an implicit build to an explicit build to match the > > systemness the implicit build would have had for a given module. > > I had another thought. Wh

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

Bigcheese marked 2 inline comments as done. Bigcheese added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1912 +Diags.Report(diag::err_drv_argument_only_allowed_with) << "-fsystem-module" + <<

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

dexonsmith added inline comments. Comment at: clang/include/clang/Driver/Options.td:1448 Flags<[CC1Option]>, Alias; +def fsystem_module : Flag<["-"], "fsystem-module">, Flags<[CC1Option]>, + HelpText<"Build this module as a system module. Only used with -emit-module">; -

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

dexonsmith added a comment. > This is used when > converting an implicit build to an explicit build to match the > systemness the implicit build would have had for a given module. I had another thought. What if for the explicitly built "system" modules: - If `-Wsystem-headers` is on, leave th

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

bruno added a comment. Hi Michael, thanks for improving this. Comment at: clang/include/clang/Driver/Options.td:1448 Flags<[CC1Option]>, Alias; +def fsystem_module : Flag<["-"], "fsystem-module">, Flags<[CC1Option]>, + HelpText<"Build this module as a system module. Only us

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

Bigcheese created this revision. Bigcheese added reviewers: rsmith, bruno. Bigcheese added a project: clang. Herald added a subscriber: dexonsmith. The -fsystem-module flag is used when explicitly building a module. It forces the module to be treated as a system module. This is used when convertin