[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy

2020-03-02 Thread Alexandre Ganea via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7e77cf473ac9: [Clang] Fix Hurd toolchain test on a two-stage build with ThinLTO (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D75373?vs=247542&id=247715#toc Repository: rG L

[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy

2020-03-02 Thread Kristina Brooks via Phabricator via cfe-commits
kristina accepted this revision. kristina added a comment. This revision is now accepted and ready to land. In D75373#1900237 , @aganea wrote: > The patch did not make sense conceptually. Hurd is not Linux. I think now it > makes more sense. Yes this se

[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy

2020-03-02 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In D75373#1898620 , @aganea wrote: > @hans, do you think this could be included in 10.0? I think it's too late in the process for this, maybe it can be merged for 10.0.1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7537

[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy

2020-03-01 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea updated this revision to Diff 247542. aganea edited the summary of this revision. aganea added a comment. The patch did not make sense conceptually. Hurd is not Linux. I think now it makes more sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75373/new/ https://reviews.llvm.

[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy

2020-02-28 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea updated this revision to Diff 247400. aganea added a comment. Fix clang-formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75373/new/ https://reviews.llvm.org/D75373 Files: clang/lib/Driver/ToolChains/Hurd.cpp clang/lib/Driver/ToolChains/Hurd.h Index: clang/lib/Driv

[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy

2020-02-28 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. @hans, do you think this could be included in 10.0? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75373/new/ https://reviews.llvm.org/D75373 ___ cfe-commits mailing list cfe-com

[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy

2020-02-28 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea created this revision. aganea added reviewers: hans, sthibaul, kristina. Herald added subscribers: cfe-commits, dexonsmith, Prazek. Herald added a project: clang. aganea added a comment. @hans, do you think this could be included in 10.0? As noted in PR45061, a two-stage ThinLTO build fai