This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG47039a1a4b29: [WebAssembly] Remove restriction on main name
mangling (authored by sbc100).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
sbc100 added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360
+ auto *GA = llvm::GlobalAlias::create("__main_void", F);
+ GA->setVisibility(F->getVisibility());
+}
sbc100 wrote:
> sunfish wrote:
> > sbc100 wrote:
> > > sunfish w
sbc100 updated this revision to Diff 434605.
sbc100 added a comment.
- rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75277/new/
https://reviews.llvm.org/D75277
Files:
clang/lib/AST/Mangle.cpp
clang/lib/CodeGen/CodeGenModule.cpp
Index:
sbc100 updated this revision to Diff 433386.
sbc100 added a comment.
- feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75277/new/
https://reviews.llvm.org/D75277
Files:
clang/lib/AST/Mangle.cpp
clang/lib/CodeGen/CodeGenModule.cpp
Inde
sbc100 added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360
+ auto *GA = llvm::GlobalAlias::create("__main_void", F);
+ GA->setVisibility(F->getVisibility());
+}
sunfish wrote:
> sbc100 wrote:
> > sunfish wrote:
> > > Can this
sunfish added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360
+ auto *GA = llvm::GlobalAlias::create("__main_void", F);
+ GA->setVisibility(F->getVisibility());
+}
sbc100 wrote:
> sunfish wrote:
> > Can this use `GA->setVisibil
sbc100 added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360
+ auto *GA = llvm::GlobalAlias::create("__main_void", F);
+ GA->setVisibility(F->getVisibility());
+}
sunfish wrote:
> Can this use `GA->setVisibility(GlobalValue::Hi
sunfish added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360
+ auto *GA = llvm::GlobalAlias::create("__main_void", F);
+ GA->setVisibility(F->getVisibility());
+}
Can this use `GA->setVisibility(GlobalValue::HiddenVisibility)`
sbc100 updated this revision to Diff 433191.
sbc100 added a comment.
- revert parts
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75277/new/
https://reviews.llvm.org/D75277
Files:
clang/lib/AST/Mangle.cpp
clang/lib/CodeGen/CodeGenModule.cpp
sbc100 added inline comments.
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp:264
- }
-}
}
sunfish wrote:
> Why is this code going away? This isn't Emscripten-specific code.
Ah.. I was hoping we could delete these codepaths,
sunfish added inline comments.
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp:264
- }
-}
}
Why is this code going away? This isn't Emscripten-specific code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
sbc100 updated this revision to Diff 433173.
sbc100 added a comment.
- update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75277/new/
https://reviews.llvm.org/D75277
Files:
clang/lib/AST/Mangle.cpp
clang/lib/CodeGen/CodeGenModule.cpp
llvm/l
sbc100 added a comment.
Currently waiting on https://github.com/emscripten-core/emscripten/pull/17099
to land.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75277/new/
https://reviews.llvm.org/D75277
__
sbc100 updated this revision to Diff 433138.
sbc100 added a comment.
Herald added subscribers: llvm-commits, asb, hiraditya.
Herald added a project: LLVM.
- update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75277/new/
https://reviews.llvm.org/D7
sbc100 created this revision.
Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google,
dschuff.
Herald added a project: clang.
Emscripten now handles/supports this new mode.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D75277
Files:
clang/lib/AST/Mangle.c
15 matches
Mail list logo
