[PATCH] D75097: [cc1as] Unset UseNamesOnTempLabels

2020-02-25 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D75097#1892545 , @efriedma wrote: > In terms of tests, we can add cc1as tests to clang/test/Misc; just need to be > marked `REQUIRES: arm-registered-target` or something like that. > > That said, if we need to write cc1as-speci

[PATCH] D75097: [cc1as] Unset UseNamesOnTempLabels

2020-02-25 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. In terms of tests, we can add cc1as tests to clang/test/Misc; just need to be marked `REQUIRES: arm-registered-target` or something like that. That said, if we need to write cc1as-specific tests for anything other than the command-line parsing, probably something has g

[PATCH] D75097: [cc1as] Unset UseNamesOnTempLabels

2020-02-25 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Does UseNamesOnTempLabels really need to be configurable? If we're going to force it to false everywhere, might as well just get rid of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75097/new/ https://reviews.llvm.or

[PATCH] D75097: [cc1as] Unset UseNamesOnTempLabels

2020-02-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added a reviewer: efriedma. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to rL236642 . This fixes https://reviews.llvm.org/D74006#1890487 Repository: rG LLVM Github Monorepo https://re