[PATCH] D75068: libclang: Add static build support for Windows

davezarzycki added a comment. In D75068#2004885 , @cristian.adam wrote: > In D75068#2004072 , @davezarzycki > wrote: > > > Rather than wholly reverting this, I committed a fix: > > 665471907a5c072c6653a38c35f35e5

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. In D75068#2004072 , @davezarzycki wrote: > Rather than wholly reverting this, I committed a fix: > 665471907a5c072c6653a38c35f35e5d54cef220 > > > The pr

[PATCH] D75068: libclang: Add static build support for Windows

davezarzycki added a comment. Rather than wholly reverting this, I committed a fix: 665471907a5c072c6653a38c35f35e5d54cef220 The problem is that "NOT LIBCLANG_BUILD_STATIC" does not imply PIC, so there is no point in trying

[PATCH] D75068: libclang: Add static build support for Windows

davezarzycki added a comment. This breaks building libclang on Fedora 32 with clang 10.0 and lld 10.0. Do you mind if I revert this tomorrow if a quick fix cannot be found? Here is the relevant diagnostics: FAILED: lib64/libclang.so.11 : && /usr/bin/clang++ -fPIC -Werror=switch -stdlib=libc++

[PATCH] D75068: libclang: Add static build support for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fb80d9383e4: libclang: Add static build support for Windows (authored by cristian.adam, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam marked an inline comment as done. cristian.adam added a comment. @mstorsjo can you merge (again) this on my behalf? Thank you in advance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam marked an inline comment as done. cristian.adam added a comment. Since I do not have commit rights, I require help to get this merged. Comment at: clang/tools/libclang/CMakeLists.txt:88 +if (WIN32 AND ENABLE_SHARED AND ENABLE_STATIC) + unset(ENABLE_STATIC)

[PATCH] D75068: libclang: Add static build support for Windows

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, assuming my understanding is correct. Comment at: clang/tools/libclang/CMakeLists.txt:88 +if (WIN32 AND ENABLE_SHARED AND ENABLE_STATIC) + unset(ENABLE_STATIC) ---

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. @thakis ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. Ping. I find it a bit uncool to revert commits and then be away for a month. I guess it's my fault for not making the patch perfect in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https:

[PATCH] D75068: libclang: Add static build support for Windows

mstorsjo added a comment. @thakis? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D75068: libclang: Add static build support for Windows

mstorsjo added a comment. @thakis? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. I've tested this patch with: -D LIBCLANG_BUILD_STATIC=OFF -D LLVM_ENABLE_PIC=ON All green https://github.com/cristianadam/llvm-project/actions/runs/44839699 Then: -D LIBCLANG_BUILD_STATIC=ON -D LLVM_ENABLE_PIC=OFF All green https://github.com/cristianada

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam created this revision. cristian.adam added reviewers: yvvan, thakis, mstorsjo. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. This patch is a squash for: https://reviews.llvm.org/D74564 https://reviews.llvm.org/D74907 And a fix for the issue that got