This revision was automatically updated to reflect the committed changes.
Closed by commit rG34d0e1bd6d05: [clangd] Expose the rename LimitFiles option
to the C++ API, NFC. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D74834?vs=246640&id=246641#toc
Repository:
rG L
hokein updated this revision to Diff 246640.
hokein added a comment.
keep the old clangdServer::rename around temporarily to make internal
integration life easier.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74834/new/
https://reviews.llvm.org/D
hokein updated this revision to Diff 245852.
hokein marked 2 inline comments as done.
hokein added a comment.
address review comments - move the options to clangdServer::rename API
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74834/new/
https://re
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.h:145
-/// Enable cross-file rename feature.
-bool CrossFileRename = false;
+/// Options for rename.
+RenameOptions RenameOpts;
rename is just a normal API call,
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D74834
Files:
clang-tools-extra/clangd/Clan