[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman added a comment. Submitted https://github.com/llvm/llvm-project/commit/7d91633a2b9b1f563dc14c632cc0c461c3651f76 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790 __

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman added a comment. In D74790#1883466 , @dyung wrote: > `The test you added in this change seems to be failing on Windows, can you > take a look? > > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/14409 > > FAIL: Clang :: CodeComp

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dyung added a comment. The test you added in this change seems to be failing on Windows, can you take a look? http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/14409 FAIL: Clang :: CodeCompletion/included-symlinks.cpp (1779 of 16867) - TEST 'Clang :: CodeCompletion/included-symli

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

This revision was automatically updated to reflect the committed changes. Closed by commit rGf50fe5eb6d2e: [Sema][CodeComplete] Handle symlinks for include code completion (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/ne

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman marked 3 inline comments as done. dgoldman added a comment. In D74790#1881827 , @sammccall wrote: > Thanks! I can't see this being a performance problem (famous last words...) Technically it is capped at 2500 symlinks =) fingers crossed Reposi

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman updated this revision to Diff 245415. dgoldman added a comment. - Fixes for Sam's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! I can't see this being a performance problem (famous last words...) Comment at: clang/lib/Sema/SemaCodeComplete.cpp:8780 + + // We need to manually resolve

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman updated this revision to Diff 245256. dgoldman added a comment. - Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/CodeComplet

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously any symlinks would be ignored since the directory traversal doesn't follow them. With this change we now follow symlinks (via a `stat` call in or