This revision was automatically updated to reflect the committed changes.
Closed by commit rGff7b5bac04fa: [clangd] Expose Code Completion score to the
client (authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74547/new/
https://r
kbobyrev updated this revision to Diff 244412.
kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.
Make a note that score is Clangd extension.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74547/new/
https://reviews.llvm.org/D74547
kbobyrev updated this revision to Diff 244402.
kbobyrev added a comment.
Replace actual scores with regex for stability.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74547/new/
https://reviews.llvm.org/D74547
Files:
clang-tools-extra/clangd/Cod
kbobyrev updated this revision to Diff 244403.
kbobyrev added a comment.
Replace one instance of hardcoded score missed in the previous update.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74547/new/
https://reviews.llvm.org/D74547
Files:
clang
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/Protocol.h:1100
+ /// NOTE: This excludes fuzzy matching score which is typically calculated on
+ /// the client side.
+ flo
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/test/protocol.test:42
# CHECK-NEXT:"label": " a",
+# CHECK-NEXT:"score": 13.20762939453,
# CHECK-NEXT:"sortText": "{{.*}}"
oops, raced with you...
you missed some
kbobyrev created this revision.
kbobyrev added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous,
MaskRay, ilya-biryukov.
Herald added a project: clang.
Make it possible for the client to adjust the ranking by using the score Clangd
calculates fo
