LukeGeeson closed this revision.
LukeGeeson marked an inline comment as not done.
LukeGeeson added inline comments.
Comment at: llvm/unittests/Support/TargetParserTest.cpp:784
EXPECT_TRUE(testAArch64CPU(
+ "cortex-a34", "armv8-a", "crypto-neon-fp-armv8",
+ AArch64::A
SjoerdMeijer added a comment.
Cheers, LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74483/new/
https://reviews.llvm.org/D74483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
LukeGeeson updated this revision to Diff 244377.
LukeGeeson marked an inline comment as done.
LukeGeeson added a comment.
- Added MIDR to Host.cpp
- Fixed a clang test I missed (copy/paste error)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74483/new/
https://reviews.llvm.org/D74483
F
SjoerdMeijer added a comment.
Ah, sorry, looks like this is all there is to it, both clang and llvm. It's
just that a quick grep locally (for a similar core) showed some more results.
Can you (double) check if it needs adding to e.g. a switch in
`llvm/lib/Support/Host.cpp`?
Repository:
rG L
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Looks like the usual business of adding a cpu to me, with one nit inlined that
can be fixed before committing.
Looks like you're doing the LLVM part separately. Now with the monore
LukeGeeson created this revision.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls.
Herald added projects: clang, LLVM.
This patch upstreams support for the AArch64 Armv8-A cpu Cortex-A34.
