[PATCH] D74130: [clang] fix consteval call in default arguments

Tyker added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2393 InitScope.pop(); aaron.ballman wrote: > Is there a reason we're not moving this one to below > `AddInititializerToDecl()` as we did elsewhere? yes, It was causing a few test f

[PATCH] D74130: [clang] fix consteval call in default arguments

Tyker updated this revision to Diff 382702. Tyker added a comment. In D74130#3085313 , @aaron.ballman wrote: > FWIW, I am not seeing double errors on that code. Here's the output I get > with this patch applied locally: > > F:\source\llvm-project>cat "

[PATCH] D74130: [clang] fix consteval call in default arguments

aaron.ballman added a comment. In D74130#3079630 , @Tyker wrote: > In D74130#3073271 , @aaron.ballman > wrote: > >> @Tyker -- are you planning to pick this review back up again sometime in the >> near future? If n

[PATCH] D74130: [clang] fix consteval call in default arguments

Tyker updated this revision to Diff 381416. Tyker added a comment. In D74130#3073271 , @aaron.ballman wrote: > @Tyker -- are you planning to pick this review back up again sometime in the > near future? If not, do you care if the review gets commandeered

[PATCH] D74130: [clang] fix consteval call in default arguments

aaron.ballman added a comment. @Tyker -- are you planning to pick this review back up again sometime in the near future? If not, do you care if the review gets commandeered? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74130/new/ https://reviews.

[PATCH] D74130: [clang] fix consteval call in default arguments

rsmith added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1026 + HandleImmediateInvocations(ExprEvalContexts.back()); + Tyker wrote: > rsmith wrote: > > What do we need this for? If I'm understanding the patch correctly, I think > > the only way we sh

[PATCH] D74130: [clang] fix consteval call in default arguments

Tyker updated this revision to Diff 298818. Tyker marked 9 inline comments as done. Tyker added a comment. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74130/new/ https://reviews.llvm.org/D74130 Files: clang/include/clang/AS

[PATCH] D74130: [clang] fix consteval call in default arguments

Tyker added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1026 + HandleImmediateInvocations(ExprEvalContexts.back()); + rsmith wrote: > What do we need this for? If I'm understanding the patch correctly, I think > the only way we should propagate immed

[PATCH] D74130: [clang] fix consteval call in default arguments

rsmith added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2928 + SmallVectorImpl &ParamInfo, + SourceLocation &EllipsisLoc, bool InConstantConstext = false); void ParseBracketDeclarator(Declarator &D); Comment a