This revision was automatically updated to reflect the committed changes.
Closed by commit rG5911268e441c: [analyzer] Improve FuchsiaHandleChecker's
diagnostic messages (authored by xazax.hun).
Changed prior to commit:
https://reviews.llvm.org/D73229?vs=239698&id=239924#toc
Repository:
rG LL
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:363
} else
-return "";
+return std::string{};
});
xazax.hun wrote:
> NoQ wrote:
> > What was wrong with good old `""`?
>
xazax.hun marked an inline comment as done.
xazax.hun added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:363
} else
-return "";
+return std::string{};
});
NoQ wrote:
> What was
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Nice! These are indeed useful when multiple things can happen. You may also
consider adding stack hints a-la `MallocChecker` (i.e., "Returning; handle was
closed").
Comment at: c
xazax.hun created this revision.
xazax.hun added reviewers: NoQ, haowei.
xazax.hun added a project: clang.
Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware.
I found that this information is useful when t
