[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62094 tests passed, 0 failed and 785 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

This revision was automatically updated to reflect the committed changes. Closed by commit rG9570f1e5a612: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73101/

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet updated this revision to Diff 239523. kadircet marked 2 inline comments as done. kadircet added a comment. - Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73101/new/ https://reviews.llvm.org/D73101 Files: clang-tools-ext

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FindTarget.cpp:585 + // We choose to only visit TemplatedDecls for {Class, Function, Var, + // TypeAlias} TemplateDecls. As

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62057 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet updated this revision to Diff 239320. kadircet marked an inline comment as done. kadircet added a comment. - Filter out templateddecls in VisitNamedDecls, instead of defining a new Visit method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62057 tests passed, 0 failed and 784 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:584 +void VisitRedeclarableTemplateDecl(const RedeclarableTemplateDecl *TD) { + // {Class,Function,Var,TypeAlias}TemplateDecls are visited as pa

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:584 +void VisitRedeclarableTemplateDecl(const RedeclarableTemplateDecl *TD) { + // {Class,Function,Var,TypeAlias}TemplateDecls are visited as pa

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:584 +void VisitRedeclarableTemplateDecl(const RedeclarableTemplateDecl *TD) { + // {Class,Function,Var,TypeAlias}TemplateDecls are visited as part of the + // NamedDecl below, we skip

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet updated this revision to Diff 239310. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73101/new/ https://reviews.llvm.org/D73101 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73101 Files: clang-tools-extra/clangd/