[PATCH] D73062: [analyzer] Simplify BoolAssignmentChecker

2020-01-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG88c7b1642079: [analyzer] Simplify BoolAssignmentChecker (authored by Mikhail Gadelha ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D73062: [analyzer] Simplify BoolAssignmentChecker

2020-01-27 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. That's more like it! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73062/new/ https://reviews.llvm.org/D73062 ___ cfe-commits mailing list

[PATCH] D73062: [analyzer] Simplify BoolAssignmentChecker

2020-01-21 Thread Mikhail Ramalho via Phabricator via cfe-commits
mikhail.ramalho updated this revision to Diff 239397. mikhail.ramalho added a comment. Update the condition to flag an issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73062/new/ https://reviews.llvm.org/D73062 Files: clang/lib/StaticAnalyzer/Checkers/BoolAssignmentChecker.cpp I

[PATCH] D73062: [analyzer] Simplify BoolAssignmentChecker

2020-01-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Thanks!!! Small patches are so nice to review. Comment at: clang/lib/StaticAnalyzer/Checkers/BoolAssignmentChecker.cpp:91 - if (!greaterThanEqualToZero) { -// The SValBuilder cannot construct a valid SVal for this condition. -// This means we can

[PATCH] D73062: [analyzer] Simplify BoolAssignmentChecker

2020-01-20 Thread Mikhail Ramalho via Phabricator via cfe-commits
mikhail.ramalho created this revision. mikhail.ramalho added a reviewer: NoQ. Herald added subscribers: cfe-commits, Charusso. Herald added a project: clang. mikhail.ramalho retitled this revision from "Simplify BoolAssignmentChecker" to "[analyzer] Simplify BoolAssignmentChecker". Herald added su