[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rsmith added a comment. In D72897#1832234 , @vvereschaka wrote: > Hi Richard, > > http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l builder has been > broken by this patch during few days (failed "Clang::virtual-compare.cpp" > test). > Sorry, bu

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

vvereschaka added a comment. Hi Richard, http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l builder has been broken by this patch during few days (failed "Clang::virtual-compare.cpp" test). Sorry, but I'm going to revert these changes. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

alanphipps added a comment. This test is still failing on the arm bots and also with my downstream ARM compiler validation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72897/new/ https://reviews.llvm.org/D72897 ___

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

peter.smith added a comment. It is also failing on the other 32-bit arm bots, example http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/13052/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Avirtual-compare.cpp Looking at the failure // CHECK-SAME: @_ZThn8_N1AD1Ev and the out

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

RKSimon added a comment. @rsmith This is failing on http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/3169 - please can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72897/new/ https://reviews.llvm.org/D72897 __

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

This revision was automatically updated to reflect the committed changes. Closed by commit rGadd2b7e44ada: List implicit operator== after implicit destructors in a vtable. (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72897/new/

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. It wouldn't be a bad idea to track that correspondence in the AST just on the general principle that it's useful information (for diagnostics, tooling, etc.) that's otherwise hard to recre

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rsmith updated this revision to Diff 238881. rsmith added a comment. - Explicitly put implicit virtual functions in the right order, rather Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72897/new/ https://reviews.llvm.org/D72897 Files: clang/lib

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rsmith added a comment. In D72897#1825791 , @rjmccall wrote: > I know that Sema used to have a lot of issues with implicitly declaring > special members, but I also know that that was bound up with how we tracked > special state for the class, and that c

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rjmccall added a comment. I see two reasonable approaches here: we can rely on the implicit members being added in the right order by Sema, as this patch seems to do, or we can broaden the special treatment of implicit virtual functions in the v-table layout code. The latter is more complex (w

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. We previously listed first declared members, then implicit operator=, then implicit operator==, then implicit destructors. Per discussion on https://github.com/it