[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte abandoned this revision. DieGoldeneEnte added a comment. Adding the paths for llvm/lld is not needed, because GetProgramPath is actually also searching in $PATH. This means D72903 already is enough to fix my problem. CHANGES SINCE LAST ACTION

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

tra added a comment. Tank you for splitting the patch. For CMake parts @beanz would be the person to make the call. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72806/new/ https://reviews.llvm.org/D72806 ___ cfe-commits mailing list cfe-c

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte updated this revision to Diff 238708. DieGoldeneEnte added a comment. This patch now only adds the executable dirs to the program path, the code to search them is now in D72903 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72806/new/ ht

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

tra added a comment. In D72806#1825400 , @DieGoldeneEnte wrote: > > Even in case we don't add the extra directories for llvm and lld, it would be > a good idea to use the getProgramPath function instead of building it > manually (so only the changes

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte added a comment. In D72806#1825362 , @tra wrote: > In D72806#1825333 , @DieGoldeneEnte > wrote: > > > In D72806#1824560 , @yaxunl wrote: > > > > > What's the

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

tra added a comment. In D72806#1825333 , @DieGoldeneEnte wrote: > In D72806#1824560 , @yaxunl wrote: > > > What's the use case of this change? > > > > Normally clang needs to call opt/llc/lld from the same director

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte updated this revision to Diff 238645. DieGoldeneEnte added a comment. The build doesn't fail anymore if lld is not present, also one can set LLD_BINARY_DIR manually. I also exchanged TOOLS_BINARY_DIR with LLVM_TOOLS_BINARY_DIR, since it is better readable and if compiled with llvm

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte added a comment. In D72806#1824560 , @yaxunl wrote: > What's the use case of this change? > > Normally clang needs to call opt/llc/lld from the same directory of clang. > Why do we need to find them in other directories? My motivation is

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

tra added a reviewer: beanz. tra added a subscriber: beanz. tra added a comment. LGTM. Added @beanz for the review of CMake file changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72806/new/ https://reviews.llvm.org/D72806 _

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

yaxunl added a comment. What's the use case of this change? Normally clang needs to call opt/llc/lld from the same directory of clang. Why do we need to find them in other directories? Where is TOOLS_BINARY_DIR defined? Also we cannot let the build fail because of lld not found, since users ma

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte created this revision. DieGoldeneEnte added a reviewer: yaxunl. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. The previous code constructed the executable paths for llvm-link, opt, lld, llc and clang-offload-bundler for the path to the compiler. This