[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

kuhnel added a comment. thx for the feedback, I created an issue for this: https://github.com/google/llvm-premerge-checks/issues/98 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72715/new/ https://reviews.llvm.org/D72715 ___

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f946ee2faba: [clang][CodeComplete] Propogate printing policy to FunctionDecl (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72715/new

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

hokein accepted this revision. hokein added a subscriber: kuhnel. hokein added a comment. This revision is now accepted and ready to land. @kuhnel, I think we should exclude from running clang-format on lint test files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61796 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

kadircet added a comment. In D72715#1819879 , @ilya-biryukov wrote: > The patch contains only tests, are we missing the actual functional change? oopsy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72715/

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

kadircet updated this revision to Diff 238017. kadircet added a comment. - Upload the correct diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72715/new/ https://reviews.llvm.org/D72715 Files: clang-tools-extra/clangd/unittests/CodeCompleteTes

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

ilya-biryukov added a comment. The patch contains only tests, are we missing the actual functional change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72715/new/ https://reviews.llvm.org/D72715 ___ c

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61795 tests passed, 1 failed and 781 were skipped. failed: Clangd Unit Tests._/ClangdTests/SignatureHelpTest.PartialSpec {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clan

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. Printing policy was not propogated to functiondecls when creating a completion string which resulted in canonical template p