[PATCH] D72581: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

2020-04-01 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko marked 5 inline comments as done. hlopko added a comment. I'm submitting this patch at https://reviews.llvm.org/D77209 (with Ilya's permission). Let's continue the review there. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:228 + /// multiple times and this f

[PATCH] D72581: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

2020-01-21 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:228 + /// multiple times and this function will return multiple results in those + /// cases. This happens

[PATCH] D72581: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

2020-01-12 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61746 tests passed, 0 failed and 780 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72581: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

2020-01-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a project: clang. Same restrictions apply as in the other direction: macro arguments are not supported yet, only full macro expansions can be mapped. Repository: rG LLVM Github Monorepo https://review