[PATCH] D72334: [Syntax] Build nodes for template declarations.

gribozavr2 added a comment. Superseded by https://reviews.llvm.org/D76346. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72334/new/ https://reviews.llvm.org/D72334 ___ cfe-commits mailing list cfe-comm

[PATCH] D72334: [Syntax] Build nodes for template declarations.

hlopko added a comment. Let's continue the review at https://reviews.llvm.org/D76346. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:190 + // Set role for the node that may or may not be delayed. Node must span + // exactly \p Range. + void markMaybeDelayedChild(llvm::Ar

[PATCH] D72334: [Syntax] Build nodes for template declarations.

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:930 +Builder.markChildToken(TemplateKW, syntax::NodeRole::IntroducerKeyword); +Builder.markMaybeDelayedChild( +TemplatedDeclaration, Why is this range maybe-delay

[PATCH] D72334: [Syntax] Build nodes for template declarations.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:190 + // Set role for the node that may or may not be delayed. Node must span + // exactly \p Range. + void

[PATCH] D72334: [Syntax] Build nodes for template declarations.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61849 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72334: [Syntax] Build nodes for template declarations.

ilya-biryukov updated this revision to Diff 238023. ilya-biryukov added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72334/new/ https://reviews.llvm.org/D72334 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/To

[PATCH] D72334: [Syntax] Build nodes for template declarations.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72334: [Syntax] Build nodes for template declarations.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72334: [Syntax] Build nodes for template declarations.

ilya-biryukov updated this revision to Diff 236583. ilya-biryukov added a comment. - Cosmetics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72334/new/ https://reviews.llvm.org/D72334 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib

[PATCH] D72334: [Syntax] Build nodes for template declarations.

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr2. Herald added a project: clang. ilya-biryukov added a parent revision: D72089: [Syntax] Build declarator nodes. ilya-biryukov updated this revision to Diff 236583. ilya-biryukov added a comment. - Cosmetics Handles t