[PATCH] D72089: [Syntax] Build declarator nodes

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Superseded by https://reviews.llvm.org/D76220. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72089/new/ https://reviews.llvm.org/D72089

[PATCH] D72089: [Syntax] Build declarator nodes

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1210 + `-; + )txt"}, }; hlopko wrote: > gribozavr2 wrote: > > A few complex tests that combine multiple declarators would be nice > > (especially to test that the

[PATCH] D72089: [Syntax] Build declarator nodes

hlopko added a comment. I'm taking over of this patch (with a kind permission from Ilya :) I've replied to comments here, but let's continue the review over at https://reviews.llvm.org/D76220. Thanks :) Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:395 } + /// FI

[PATCH] D72089: [Syntax] Build declarator nodes

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:395 } + /// FIXME: use custom iterator instead of 'vector'. + std::vector declarators(); s/iterator/container/ ? Also unclear why a custom one should be used. I also t

[PATCH] D72089: [Syntax] Build declarator nodes

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61848 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72089: [Syntax] Build declarator nodes

ilya-biryukov updated this revision to Diff 238022. ilya-biryukov added a comment. - Rebase, get rid of accidental changes with TemplateDeclaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72089/new/ https://reviews.llvm.org/D72089 Files: c

[PATCH] D72089: [Syntax] Build declarator nodes

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72089: [Syntax] Build declarator nodes

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr2. Herald added a project: clang. ilya-biryukov added a parent revision: D72072: [AST] Respect shouldTraversePostOrder when traversing type locs. They cover part of types and names for some declarations, including commo