[PATCH] D72053: [RFC] Handling implementation limits

Mordante marked 6 inline comments as done. Mordante added a comment. Thanks for the feedback! Comment at: clang/include/clang/AST/Decl.h:903 /// declared. -unsigned ScopeDepthOrObjCQuals : NumScopeDepthOrObjCQualsBits; +unsigned ScopeDepthOrObjCQuals : IQ::NumScope

[PATCH] D72053: [RFC] Handling implementation limits

rsmith added inline comments. Comment at: clang/include/clang/AST/Decl.h:903 /// declared. -unsigned ScopeDepthOrObjCQuals : NumScopeDepthOrObjCQualsBits; +unsigned ScopeDepthOrObjCQuals : IQ::NumScopeDepthOrObjCQualsBits; These bitfields are assum

[PATCH] D72053: [RFC] Handling implementation limits

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/docs/ImplementationQuantities.rst:11 +This page lists the limits implemented in the Clang compiler. The available +resources on the system running Clang may imposse other limits. For exam

[PATCH] D72053: [RFC] Handling implementation limits

tahonermann added inline comments. Comment at: clang/docs/ImplementationQuantities.rst:11 +This page lists the limits implemented in the Clang compiler. The available +resources on the system running Clang may imposse other limits. For example, +the system may have insufficient m

[PATCH] D72053: [RFC] Handling implementation limits

Mordante updated this revision to Diff 236248. Mordante marked an inline comment as done. Mordante added a comment. Made some improvements based on feedback of @craig.topper: - Adds a not - Implements an example of the maximum string length when using -Wpedantic CHANGES SINCE LAST ACTION http

[PATCH] D72053: [RFC] Handling implementation limits

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/docs/ImplementationQuantities.rst:70 + +These limits are defined in the standards, but are imposed in Clang. + craig.topper wrote: > should this say ‘not defined’? Yes, t

[PATCH] D72053: [RFC] Handling implementation limits

craig.topper added inline comments. Comment at: clang/docs/ImplementationQuantities.rst:70 + +These limits are defined in the standards, but are imposed in Clang. + should this say ‘not defined’? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72053/new/

[PATCH] D72053: [RFC] Handling implementation limits

Mordante updated this revision to Diff 236190. Mordante added a comment. Added support for some additional features: - Allow limits from the C standard, either sharing the C++ constants or separately. - Allow to document the design choices for the limit. - Allow to track the status of the limit.

[PATCH] D72053: [RFC] Handling implementation limits

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61168 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72053: [RFC] Handling implementation limits

Mordante created this revision. Mordante added a project: clang. Herald added a subscriber: mgorny. This is a proof-of-concept patch to be discussed on the dev ml. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72053 Files: clang/docs/ImplementationQuantities.rst clang/doc