[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

Mordante added a comment. Sorry I missed your message. At the moment I don't intend to continue with this review. Do you want to commandeer this one or do you prefer me to abandon it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71966/new/ https://reviews.llvm.org/D71966

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

aaronpuchert added a comment. Herald added a project: clang-tools-extra. @Mordante, do you have plans to get back to this? Otherwise I'd like to pick it up. I'd probably concentrate on multiple parameter support for now, and delegate identifier validation, typo correction for variadic functions

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

aaronpuchert added a comment. Thanks for working on this, I'd like to see this being fixed. Comment at: clang/include/clang-c/Documentation.h:383 CINDEX_LINKAGE -CXString clang_ParamCommandComment_getParamName(CXComment Comment); gribozavr2 wrote: > Mordante

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

Mordante planned changes to this revision. Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:1121 + if (isFunctionOrMethodVariadic() && + Typo.find_first_not_of('.') == StringRef::npos) +return ParamComm

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

gribozavr2 added a comment. In D71966#1840957 , @Mordante wrote: > So if I understand correctly: > > - `getParamNameAsWritten` will become `getArgText` > - The `getParamName` will do the translation from the name in the > documentation to the name in the

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

Mordante marked 2 inline comments as done. Mordante added a comment. So if I understand correctly: - `getParamNameAsWritten` will become `getArgText` - The `getParamName` will do the translation from the name in the documentation to the name in the current function declaration. If the parameter

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

gribozavr2 added inline comments. Comment at: clang/include/clang-c/Documentation.h:383 CINDEX_LINKAGE -CXString clang_ParamCommandComment_getParamName(CXComment Comment); Mordante wrote: > gribozavr2 wrote: > > Please don't modify existing APIs in libclang --

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

Mordante marked 14 inline comments as done. Mordante added a comment. Thanks for the review! I only answered to the larger issues to get a better feeling of the direction the patch should go. Once that's clear I'll make a new patch and also address the smaller issues. Commen

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

gribozavr2 added a comment. Thank you for the patch! Comment at: clang/docs/ReleaseNotes.rst:68 +- -Wdocumentation properly handles Doxygen comments with multiple identifiers in + one \param command. The validation whether the name of the identifier is valid + has been impr

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings . {icon times-circle color=red} clang-forma

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

Mordante added a comment. The merge bot noticed I forgot to update clang's unittests. Will look at that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71966/new/ https://reviews.llvm.org/D71966 ___ cfe

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings . {icon times-circle color=red} clang-forma