[PATCH] D71555: [clangd] Refurbish HoverInfo::present

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61307 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

This revision was automatically updated to reflect the committed changes. Closed by commit rG287a874d1c46: [clangd] Refurbish HoverInfo::present (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.or

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet updated this revision to Diff 236993. kadircet added a comment. - Change `Value:` to `Value =` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.org/D71555 Files: clang-tools-extra/clangd/Hover.cpp clang-to

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

sammccall accepted this revision. sammccall added a comment. still LG, go ahead and we can iterate Comment at: clang-tools-extra/clangd/Hover.cpp:495 +markup::Paragraph &P = Output.addParagraph(); +P.appendText("Value: "); +P.appendCode(*Value); kad

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61307 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet updated this revision to Diff 236976. kadircet marked 10 inline comments as done. kadircet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.org/D71555 Files: clang-tools-ext

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:466 + markup::Paragraph &P = Output.addParagraph(); + P.appendText(beautify(index::getSymbolKindString(Kind))); + if (!Name.empty()) { sammccall wrote: > kadircet wrote: > > sammcca

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great stuff, let's finally ship it! Comment at: clang-tools-extra/clangd/Hover.cpp:466 + markup::Paragraph &P = Output.addParagraph(); + P.appendText(beautify(index::

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61307 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet updated this revision to Diff 236842. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.org/D71555 Files: clang-tools-ex

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet marked 23 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:393 +// Converts a string of the form `word1-word2-...` into `Word1 Word2 ...`. +std::string beautify(llvm::StringRef Input) { + std::string Res; --

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:393 +// Converts a string of the form `word1-word2-...` into `Word1 Word2 ...`. +std::string beautify(llvm::StringRef Input) { + std::string Res; It's worth noting that an alternativ

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json , CMakeCache.txt

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json , CMakeCache.txt

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet updated this revision to Diff 234087. kadircet added a comment. - Get rid of irrelevant change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.org/D71555 Files: clang-tools-extra/clangd/Hover.cpp clang-to

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Improves basic hover presentation logic to include more info. Repository: rG LLVM Github Monorepo