Re: [PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

2019-12-13 Thread Eric Christopher via cfe-commits
On Fri, Dec 13, 2019 at 1:18 PM Dávid Bolvanský via Phabricator < revi...@reviews.llvm.org> wrote: > xbolva00 added a comment. > > In D71486#1784079 , @sammccall > wrote: > > > It should be possible to test this by adapting a test case from the > original e

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

2019-12-13 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. In D71486#1784079 , @sammccall wrote: > It should be possible to test this by adapting a test case from the original > ed8dadb > , but > I'm not certain...

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

2019-12-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , diff.json

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

2019-12-13 Thread Eric Christopher via Phabricator via cfe-commits
echristo updated this revision to Diff 233857. echristo added a comment. Fix for some slightly better API uses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71486/new/ https://reviews.llvm.org/D71486 Files: clang-tools-extra/clang-tidy/ClangTid

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

2019-12-13 Thread Eric Christopher via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5623bd52acd3: Fix -Wswitch-coverage warning in clang-tidy after ak_addrspace introduction. (authored by echristo). Reposi

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

2019-12-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60867 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

2019-12-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. It should be possible to test this by adapting a test case from the original ed8dadb , but I'm not certain... Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.c

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

2019-12-13 Thread Eric Christopher via Phabricator via cfe-commits
echristo created this revision. echristo added reviewers: Anastasia, sammccall. echristo added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mcrosier. Herald added a project: clang. echristo added a subscriber: rdhindsa. ... I think this is right? Add support in the switch