This revision was automatically updated to reflect the committed changes.
Closed by commit rGa0a670614a36: Call objc_retainBlock before passing a block
as a variadic argument (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D71431?vs=233851&id=233862#toc
Repository:
ahatanak marked an inline comment as done.
ahatanak added inline comments.
Comment at: clang/docs/AutomaticReferenceCounting.rst:1866
+When a block pointer type is converted to type ``id``, ``Block_copy`` is
called.
+This is necessary because a block allocated on the stack won
rjmccall accepted this revision.
rjmccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/docs/AutomaticReferenceCounting.rst:1866
+When a block pointer type is converted to type ``id``, ``Block_copy`` is
called.
+This is necessary bec
ahatanak updated this revision to Diff 233851.
ahatanak added a comment.
Explain why this change is needed in ARC documentation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71431/new/
https://reviews.llvm.org/D71431
Files:
clang/docs/Automatic
rjmccall added a comment.
Patch looks good, but could you describe this behavior in the ARC documentation?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71431/new/
https://reviews.llvm.org/D71431
___
c
ahatanak created this revision.
ahatanak added reviewers: rjmccall, arphaman.
ahatanak added a project: clang.
Herald added subscribers: ributzka, dexonsmith, jkorous.
Copy the block to the heap before passing it to the callee in case the block
escapes in the callee.
rdar://problem/55683462
Re
