Re: [PATCH] D71414: [clangd] Introduce codeblocks

Thanks Kadir, bots are back to green :) On Mon, 16 Dec 2019 at 09:18, Kadir Çetinkaya wrote: > > sent out 0f959c87cc7867beb67bfab2d5e3cf90708b2f98 > > On Mon, Dec 16, 2019 at 9:08 AM Yvan Roux wrote: >> >> Hi, it is still broken on AArch64 bots, logs are available here: >> >> http://lab.llvm.org

Re: [PATCH] D71414: [clangd] Introduce codeblocks

sent out 0f959c87cc7867beb67bfab2d5e3cf90708b2f98 On Mon, Dec 16, 2019 at 9:08 AM Yvan Roux wrote: > Hi, it is still broken on AArch64 bots, logs are available here: > > > http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/21251/steps/ninja%20check%201/logs/stdio > > Thanks, > Yv

Re: [PATCH] D71414: [clangd] Introduce codeblocks

I was actually watching for buildbots(sent out 6b8ff5e43b405d255259196b6a53a3b5671aa5c7 for fixing some breakages for example) but somehow this breakage mail didn't arrive. buildbots were in bad shape on friday it might've skipped because of that :/ Thanks for fixing this. On Sat, Dec 14, 2019 at

Re: [PATCH] D71414: [clangd] Introduce codeblocks

Hi, it is still broken on AArch64 bots, logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/21251/steps/ninja%20check%201/logs/stdio Thanks, Yvan On Sat, 14 Dec 2019 at 16:15, Nico Weber via Phabricator via cfe-commits wrote: > > thakis added inline comme

[PATCH] D71414: [clangd] Introduce codeblocks

thakis added inline comments. Comment at: clang-tools-extra/clangd/unittests/FormattedStringTests.cpp:126 +test +``` +bar)md"); Older (but still supported) gccs can't handle multiline raw strings in macro arguments, see e.g. http://lab.llvm.org:8011/builders/cl

[PATCH] D71414: [clangd] Introduce codeblocks

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c13fe8a6a64: [clangd] Introduce codeblocks (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71414/new/ https://reviews.llvm.org/D71414

[PATCH] D71414: [clangd] Introduce codeblocks

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60768 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71414: [clangd] Introduce codeblocks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:138 +// No need to pad from previous blocks, as they should end with a new line. +OS << renderCodeBlock(Contents, Language) << '\n'; + } sammccall wrote: > can you i

[PATCH] D71414: [clangd] Introduce codeblocks

kadircet updated this revision to Diff 233606. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71414/new/ https://reviews.llvm.org/D71414 Files: clang-tools-ex

[PATCH] D71414: [clangd] Introduce codeblocks

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Otherwise LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71414/new/ https://reviews.llvm.org/D71414 _

[PATCH] D71414: [clangd] Introduce codeblocks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:138 +// No need to pad from previous blocks, as they should end with a new line. +OS << renderCodeBlock(Contents, Language) << '\n'; + } can you inline renderCodeBl

[PATCH] D71414: [clangd] Introduce codeblocks

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , diff.json

[PATCH] D71414: [clangd] Introduce codeblocks

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Follow-up to the patch D71248 Repository: rG LLVM Github Monorepo