steveire added a comment.
Should this new class have some tests?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71313/new/
https://reviews.llvm.org/D71313
___
cfe-commits mailing list
cfe-commits@lists.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8a81daaa8b58: [AST] Split parent map traversal logic into
ParentMapContext.h (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D71313?vs=240050&id=240283#toc
Repository:
rG LLVM Gi
rnk added a comment.
I think I can land this version, but I'll wait until tomorrow so I'll be around
to debug fallout.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71313/new/
https://reviews.llvm.org/D71313
rnk updated this revision to Diff 240050.
rnk added a comment.
This revision is now accepted and ready to land.
- Move things around while retaining API compatibility for getParents
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71313/new/
https://r
rnk planned changes to this revision.
rnk marked an inline comment as done.
rnk added inline comments.
Comment at: clang/include/clang/AST/ASTContext.h:653
template DynTypedNodeList getParents(const NodeT &Node) {
return getParents(ast_type_traits::DynTypedNode::create(N
rnk created this revision.
rnk added reviewers: bkramer, klimek, rsmith.
Herald added subscribers: lldb-commits, kbarton, mgorny, nemanjai.
Herald added projects: clang, LLDB.
The only part of ASTContext.h that requires most AST types to be
complete is the parent map. Nothing in Clang proper uses
