[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

This revision was automatically updated to reflect the committed changes. Closed by commit rGf21c081b78ec: CodeGen: Allow annotations on globals in non-zero address space (authored by nhaehnle). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71208/new

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. In D71208#1776667 , @nhaehnle wrote: > > My concern is that there's something that's going to blow up or miscompile > > if we start passing in cons

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

nhaehnle added a comment. > My concern is that there's something that's going to blow up or miscompile if > we start passing in constants that aren't in a regular address space. Aren't > there kinds of annotations which get persisted into the emitted code? Annotations don't seem to be used for

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

rjmccall added a comment. In D71208#1776633 , @nhaehnle wrote: > In D71208#1776202 , @rjmccall wrote: > > > The questions I'd like to have answered before I can approve this are: > > > > - whether there are clients

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

nhaehnle added a comment. In D71208#1776202 , @rjmccall wrote: > The questions I'd like to have answered before I can approve this are: > > - whether there are clients of `@llvm.global.annotations` that will have > problems with non-0 address spaces and

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

rjmccall added a comment. The questions I'd like to have answered before I can approve this are: - whether there are clients of `@llvm.global.annotations` that will have problems with non-0 address spaces and - whether this will interfere with someday having an invariant that `addrspacecast` is

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

merge_guards_bot added a comment. Build result: pass - 60628 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

nhaehnle created this revision. nhaehnle added a reviewer: rjmccall. Herald added a project: clang. Attribute annotations are recorded in a special global composite variable that points to annotation strings and the annotated objects. As a restriction of the LLVM IR type system, those pointers ar