[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG074323c84658: [Driver] Default to -momit-leaf-frame-pointer for AArch64 (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D71167?vs=232714&id=233906#toc Repository: rG LLVM Git

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Okay, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71167/new/ https://reviews.llvm.org/D71167 _

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

MaskRay added a comment. In D71167#1784272 , @efriedma wrote: > If I'm understanding correctly, this does nothing without D71168 > ? And together with D71168 > , the net change for clang

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

efriedma added a comment. If I'm understanding correctly, this does nothing without D71168 ? And together with D71168 , the net change for clang is that "-mno-omit-leaf-frame-pointer" works correctly, but everything else stays t

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

MaskRay added a comment. (I got confused over the last weekend.) @efriedma We still need this driver change, otherwise D71168 will cause a functional difference when neither -m(no-)omit-leaf-frame-pointer is specified. https://godbolt.org/z/653p3q Repository

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

MaskRay added subscribers: dyung, ychen. MaskRay added a comment. In D71167#1783298 , @sdesmalen wrote: > The patch looks structurally fine, but I'm missing the argumentation for > changing the default and related, the history of why the default is to >

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

sdesmalen added a comment. The patch looks structurally fine, but I'm missing the argumentation for changing the default and related, the history of why the default is to //not// omit the frame pointer on leaf functions. Can you provide some insight here? Repository: rG LLVM Github Monorepo

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71167/new/ https://reviews.llvm.org/D71167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

MaskRay created this revision. MaskRay added reviewers: c-rhodes, efriedma, rengolin, sdesmalen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. This matches https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html > -momit-leaf-frame-pointer > -mno-omit-leaf-f