[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill marked 4 inline comments as done. chill added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1882 + if (FI.isCmseNSCall()) +FuncAttrs.addAttribute("cmse_nonsecure_call"); + snidertm wrote: > Just curious … Does the LLVM backend have a way to

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill added a comment. In D71129#1956137 , @snidertm wrote: > Have you already committed support for CMSE attributes to the LLVM backend? > Or is that on the way? The last two CMSE patches are under review: https://reviews.llvm.org/D76518 Repository:

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

snidertm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1882 + if (FI.isCmseNSCall()) +FuncAttrs.addAttribute("cmse_nonsecure_call"); + Just curious … Does the LLVM backend have a way to extract a StringRef attribute from a CallInst? I know

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

snidertm added a comment. Have you already committed support for CMSE attributes to the LLVM backend? Or is that on the way? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71129/new/ https://reviews.llvm.org/D71129 __

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

snidertm added inline comments. Comment at: clang/include/clang/AST/Type.h:3622 bool getNoCfCheck() const { return Bits & NoCfCheckMask; } bool getHasRegParm() const { return (Bits >> RegParmOffset) != 0; } chill wrote: > snidertm wrote: > > chill wro

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill marked 2 inline comments as done. chill added inline comments. Comment at: clang/include/clang/AST/Type.h:3622 bool getNoCfCheck() const { return Bits & NoCfCheckMask; } bool getHasRegParm() const { return (Bits >> RegParmOffset) != 0; } snidert

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

snidertm added inline comments. Comment at: clang/include/clang/AST/Type.h:3604 + (noCallerSavedRegs ? NoCallerSavedRegsMask : 0) | + (hasRegParm ? ((regParm + 1) << RegParmOffset) : 0) | + (NoCfCheck ? NoCfCheckMask : 0) | Wou

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill marked 3 inline comments as done. chill added inline comments. Comment at: clang/include/clang/AST/Type.h:3588 + NoCallerSavedRegsMask | NoCfCheckMask | CmseNSCallMask), RegParmOffset = 8 }; // Assumed to be the last field s

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

snidertm added inline comments. Comment at: clang/include/clang/AST/Type.h:3588 + NoCallerSavedRegsMask | NoCfCheckMask | CmseNSCallMask), RegParmOffset = 8 }; // Assumed to be the last field Shouldn't RegParmOffset be updated to

Re: [PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

From: Russell Gallop > The new case that you've added to save-temps.c doesn't work if you only build > with > DLLVM_TARGETS_TO_BUILD=X86 (i.e. not building ARM). Please could you take a > look? Yes, I've been looking into it. I may revert that test alone, until I figure out how to fix it. http

Re: [PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

Hi Momchil, Can I just check that you've seen this bot failure here since this patch: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/64604/steps/test-check-all/logs/FAIL%3A%20Clang%3A%3Asave-temps.c The new case that you've added to save-temps.c doesn't work

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG080d046c91d2: [ARM][CMSE] Implement CMSE attributes (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC