[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

This revision was automatically updated to reflect the committed changes. Closed by commit rG70c98671fa7b: [clang-format] Add option for not breaking line before ObjC params (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 240260. ghvg1313 marked an inline comment as done. ghvg1313 added a comment. - rebase master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 Files: clang/docs/Clan

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 marked 2 inline comments as done. ghvg1313 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:164 + +- Clang-format now supports JavaScript null operators. + MyDeveloperDay wrote: > is this line part of this patch? No, rebased again and got r

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:164 + +- Clang-format now supports JavaScript null operators. + is this line part of this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 239458. ghvg1313 added a comment. - rebase master - formatting code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 Files: clang/docs/ClangFormatStyleOptions.rst c

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I need you to rebase this fix, also you need to clang-format it as well. Format.h/ContinuationIndenter.cpp and FormatTestObjC.cpp all failed clang-format check Repo

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 added a comment. @MyDeveloperDay gentle ping for help merging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 ___ cfe-commits mailing list cfe-commits@

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 added a comment. In D70926#1790848 , @MyDeveloperDay wrote: > Thanks for the patch. Happy new year! Could you help landing this diff? I don't know exactly what to do from here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 __

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 marked 2 inline comments as done. ghvg1313 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:869 State.Stack[i].BreakBeforeParameter = true; if (PreviousNonComment && ghvg1313 wrote: > MyDeveloperDay wrote: > > I'm

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 234621. ghvg1313 added a comment. - Handle parameter break between blocks - Fix test cases and move them to objcTest - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:14468 + "NSNumber *v) {\n" \ + " u = v;\n" \"

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 added a comment. @MyDeveloperDay Anything I'll need to do on my end to start the landing process? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 ___ c

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 added a comment. In D70926#1769437 , @MyDeveloperDay wrote: > LGTM > > A little advice as you fix each comment check the "Done" button. > > I notice you are a new user, will you need help landing it? Thanks for the review! And yes I do need hel

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM A little advice as you fix each comment check the "Done" button. I notice you are a new user, will you need help landing it? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 232177. ghvg1313 marked an inline comment as done. ghvg1313 added a comment. - Move documents from release notes to header and proper rst, register test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay added a comment. so now I think this is better because it's encased inside your TT_ObjCMethodExpr method which means it should only impact ObjectiveC Nit on the documentation Nit missing parse tests but otherwise you are pretty close, make those changes and I'll mark accepted

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 231971. ghvg1313 marked an inline comment as done. ghvg1313 added a comment. - rename option, remove handlers for nested block itself Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.ll

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 marked an inline comment as done. ghvg1313 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:869 State.Stack[i].BreakBeforeParameter = true; if (PreviousNonComment && MyDeveloperDay wrote: > I'm a little confused by

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1651 + /// parameters in a fuction call. + bool ObjCDontBreakBeforeNestedBlockParam; + gribozavr2 wrote: > I don't know much about ClangFormat, but I'd prefer to keep the opti

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

gribozavr2 added inline comments. Comment at: clang/include/clang/Format/Format.h:1651 + /// parameters in a fuction call. + bool ObjCDontBreakBeforeNestedBlockParam; + I don't know much about ClangFormat, but I'd prefer to keep the option name positive ("ObjC

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I can tell from https://zed0.co.uk/clang-format-configurator/ that it's not possible to get it to the form you suggested, I'm not opposed to accepting this, I'm just

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 231790. ghvg1313 added a comment. - Update documents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Relea

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay added a comment. Could you update the ClangStyleOption.rst (using the tool in docs/tools) and as you are adding a new option would you add a line or two in the docs/ReleaseNotes.rst in the clang-format section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h