This revision was automatically updated to reflect the committed changes.
Closed by commit rGded249049429: Workaround for EvalInfo ctor for MSVC 2017
(authored by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D7
hliao accepted this revision.
hliao added a comment.
This revision is now accepted and ready to land.
LGTM, anyway calling a virtual function inside the constructor is not
encouraged.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70729/new/
https://reviews.llvm.org/D70729
__
yaxunl updated this revision to Diff 231101.
yaxunl added a comment.
add a test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70729/new/
https://reviews.llvm.org/D70729
Files:
clang/lib/AST/ExprConstant.cpp
clang/test/Sema/eval-info.c
Index: clang/test/Sema/eval-info.c
==
yaxunl created this revision.
yaxunl added reviewers: rjmccall, hliao.
Current EvalInfo ctor causes EnableNewConstInterp to be true even though
it is supposed to be false on MSVC 2017. This is because a virtual function
getLangOpts() is called in member initializer lists, whereas on MSVC
member ct
