This revision was automatically updated to reflect the committed changes.
Closed by commit rGddcce0f3d665: [clangd] Define out-of-line qualify function
name (authored by kadircet).
Changed prior to commit:
https://reviews.llvm.org/D70656?vs=231513&id=232042#toc
Repository:
rG LLVM Github Mon
kadircet updated this revision to Diff 231513.
kadircet added a comment.
- Update comments after rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70656/new/
https://reviews.llvm.org/D70656
Files:
clang-tools-extra/clangd/refactor/tweaks/Defi
kadircet updated this revision to Diff 231512.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70656/new/
https://reviews.llvm.org/D70656
Files:
clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cp
hokein added inline comments.
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1831
+ struct {
+llvm::StringRef Test;
+llvm::StringRef SourceFile;
maybe name them `TestHeader`, and `TestSource`.
Comment at: clang-tools-ext
merge_guards_bot added a comment.
Build result: FAILURE - Could not check out parent git hash
"0a2c8c14d3aa16ca964a8e643f9a5bfdd5459de3". It was not found in the repository.
Did you configure the "Parent Revision" in Phabricator properly? Trying to
apply the patch to the master branch instead..
merge_guards_bot added a comment.
Build result: FAILURE - Could not check out parent git hash
"0a2c8c14d3aa16ca964a8e643f9a5bfdd5459de3". It was not found in the repository.
Did you configure the "Parent Revision" in Phabricator properly? Trying to
apply the patch to the master branch instead..
kadircet created this revision.
kadircet added a reviewer: hokein.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
kadircet updated this revision to Diff 230843.
kadircet added a comment.
- Get rid of debug output
When
kadircet updated this revision to Diff 230843.
kadircet added a comment.
- Get rid of debug output
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70656/new/
https://reviews.llvm.org/D70656
Files:
clang-tools-extra/clangd/refactor/tweaks/DefineOut
