[PATCH] D70555: [coroutines] Don't build promise init with no args

2020-04-02 Thread Brian Gesiak via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG627e01feb718: [coroutines] Don't build promise init with no args (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/ https://r

[PATCH] D70555: [coroutines] Don't build promise init with no args

2020-04-02 Thread Brian Gesiak via Phabricator via cfe-commits
modocache added a comment. Of course, your approval is very welcome! 😄 I'll go ahead and land this today, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/ https://reviews.llvm.org/D70555 __

[PATCH] D70555: [coroutines] Don't build promise init with no args

2020-03-29 Thread JunMa via Phabricator via cfe-commits
junparser accepted this revision. junparser added a comment. This revision is now accepted and ready to land. I'm not sure whether I can approve this. If not, @modocache please ignore this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/

[PATCH] D70555: [coroutines] Don't build promise init with no args

2020-03-22 Thread JunMa via Phabricator via cfe-commits
junparser added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/ https://reviews.llvm.org/D70555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D70555: [coroutines] Don't build promise init with no args

2019-11-21 Thread Brian Gesiak via Phabricator via cfe-commits
modocache created this revision. modocache added reviewers: GorNishanov, rsmith, lewissbaker. Herald added subscribers: cfe-commits, EricWF. Herald added a project: clang. modocache edited the summary of this revision. In the case of a coroutine that takes no arguments, `Sema::buildCoroutinePromis