[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

itollefsen added a comment. I only build libunwind as a static library because it's (so far) the approach that gets me the furthest in avoiding all of the trouble that comes from having multiple libunwind (on Linux). I'm also running with the patch from D26244

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

saugustine added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1215 +else + CmdArgs.push_back("-l:libunwind.so"); break; itollefsen wrote: > If you are building with `-DLIBUNWIND_ENABLE_SHARED:OFF > -DLIBUNWIND_ENABLE_STAT

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

itollefsen added a comment. This fails to account for whether you actually //have// the shared and/or static version of the library. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1215 +else + CmdArgs.push_back("-l:libunwind.so"); break;

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

MaskRay closed this revision. MaskRay added a comment. Closed by 6551ac7489fe070a2edcfac88f68c93321cba9a9 The commit does not have `Differential Revision: ...` so the differential is not closed automatically. Repository:

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

jkz added a comment. In D70416#1750978 , @joerg wrote: > This is normally done by using `-Bstatic`/`-Bdynamic` around the library. See > `tools::addOpenMPRuntime`. `-Bstatic`/`-Bdynamic` wrapping does seem to be more common, but that will change the li

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

sivachandra accepted this revision. sivachandra added a comment. This revision is now accepted and ready to land. Please wait for saugustine's acceptance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70416/new/ https://reviews.llvm.org/D70416 _

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

saugustine added a comment. In D70416#1750978 , @joerg wrote: > This is normally done by using `-Bstatic`/`-Bdynamic` around the library. See > `tools::addOpenMPRuntime`. Historically, the unwind library is a little different. Gcc uses -llibgcc_eh for

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

joerg added a comment. This is normally done by using `-Bstatic`/`-Bdynamic` around the library. See `tools::addOpenMPRuntime`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70416/new/ https://reviews.llvm.org/D70416 ___

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

jkz created this revision. jkz added reviewers: saugustine, sivachandra. Herald added a project: clang. In the GNU toolchain, `-static-libgcc` implies that the unwindlib will be linked statically. However, when `--unwindlib=libunwind`, this flag is ignored, and a bare `-lunwind` is added to the