[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5181adab6183: [clangd] Expose the xref's incomplete flag to clangdServer API. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70380/new/

[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 229808. hokein marked 3 inline comments as done. hokein added a comment. address naming comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70380/new/ https://reviews.llvm.org/D70380 Files: clang-tools-ex

[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:128 +struct References { + std::vector Refs; // reference locations of the symbol. + bool InComplete = false;// true if the result is incomplete. References -> ReferenceList or Re

[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Let's see how many times I can miss the button Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70380/new/ https://reviews.llvm.org/D70380

[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Oops, LG apart from naming nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70380/new/ https://reviews.llvm.org/D70380 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: fail - 60148 tests passed, 1 failed and 729 were skipped. failed: LLVM.Bindings/Go/go.test Log files: console-log.txt , CMakeCache.txt

[PATCH] D70380: [clangd] Expose the xref's incomplete flag to clangdServer API.

2019-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. so that clangd C++ API users (via ClangdServer) can access it. Repository: rG LLVM Github Monorepo https: