This revision was automatically updated to reflect the committed changes.
Closed by commit rGbbc8662db154: [analyzer] NFC: Don't clean up range
constraints twice. (authored by dergachev.a).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70150/new/
ht
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Nice catch! I wonder if there is a case where the original code is less
wasteful, e.g. the majority of the symbols are dead and a lot of checks
splitting the execution. But this sounds v
NoQ marked an inline comment as done.
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:763-764
// generate a transition to that state.
ProgramStateRef CleanedCheckerSt =
StateMgr.getPersistentStateWithGDM(CleanedState, Checker
NoQ marked an inline comment as done.
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:763-764
// generate a transition to that state.
ProgramStateRef CleanedCheckerSt =
StateMgr.getPersistentStateWithGDM(CleanedState, Checker
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus,
baloghadamsoftware, Charusso.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho,
a.sidorin, szepet.
Herald added a project: clang.
NoQ marked an inline comment as done.
N
NoQ marked an inline comment as done.
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:750-752
// The constraint manager has not been cleaned up yet, so clean up now.
CheckerState =
getConstraintManager().removeDeadBindings(Ch
