[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

2019-11-12 Thread Mark de Wever via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG51abcebbb6e5: [OpenMP] Use an explicit copy in a range-based for (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70046/new/ https://re

[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

2019-11-11 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70046/new/ https://reviews.llvm.org/D70046 __

[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

2019-11-09 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. `OMPMappableExprListClause::const_component_lists_iterator::operator*()` returns an object and not a reference to an object. -Wrange-loop-analysis warns to make it more visible the object is a copy and not a reference. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

2019-11-09 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Why do we get the warnings with references? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70046/new/ https://reviews.llvm.org/D70046 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

2019-11-09 Thread Mark de Wever via Phabricator via cfe-commits
Mordante created this revision. Mordante added reviewers: ABataev, aaron.ballman, xbolva00. Mordante added a project: clang. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. The `std::pair>` type will be copied in a range-based for loop. Make the copy explicit to avoid the