[PATCH] D70041: register cuda language activation event and activate for .cuh files

This revision was automatically updated to reflect the committed changes. Closed by commit rG689c11486396: [clangd] register cuda language activation event and activate for .cuh files (authored by ptaylor, committed by hokein). Changed prior to commit: https://reviews.llvm.org/D70041?vs=231742&

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor updated this revision to Diff 231742. ptaylor added a comment. drop comment about vscode cuda syntax highlighting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70041/new/ https://reviews.llvm.org/D70041 Files: clang-tools-extra/clangd/cl

[PATCH] D70041: register cuda language activation event and activate for .cuh files

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. sorry for the delay, looks good, one more nit. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:91 { scheme: 'file', language: 'cpp' }

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor updated this revision to Diff 230301. ptaylor added a comment. - add package.json entry to contribute cuda language id - remove extra cuda file patterns, update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70041/new/ https://revie

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor updated this revision to Diff 230302. ptaylor added a comment. - fix package.json whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70041/new/ https://reviews.llvm.org/D70041 Files: clang-tools-extra/clangd/clients/clangd-vscode/p

[PATCH] D70041: register cuda language activation event and activate for .cuh files

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:92 + // *not* load itself automatically on '.cu' and '.cuh' files. + const cudaFilePatterns: {scheme: string, pattern: string}[] = [ +{scheme : 'file', pattern : '**/*.

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:92 + // *not* load itself automatically on '.cu' and '.cuh' files. + const cudaFilePatterns: {scheme: string, pattern: string}[] = [ +{scheme : 'file', pattern : '**/*

[PATCH] D70041: register cuda language activation event and activate for .cuh files

hokein added a comment. Thanks for the patch. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:92 + // *not* load itself automatically on '.cu' and '.cuh' files. + const cudaFilePatterns: {scheme: string, pattern: string}[] = [ +{scheme : 'file'

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor added a comment. A similar PR has been submitted to the `vscode-cpptools` repo to enable debugging CUDA files via `cuda-gdb` with the official Microsoft VSCode C++ plugin: https://github.com/microsoft/vscode-cpptools/pull/4585 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70041 Files: clang-tools-extra/clangd/clients/clangd-vscode/package.json clang-tools-ex