[PATCH] D69996: [clangd] Fixes colon escaping on Windows

lh123 added a comment. In D69996#1740412 , @hokein wrote: > I believe this patch fixes the issue, but we need to update the file > `test/semantic-highlighting.test.ts`), the test "Colorizer groups decorations > correctly" is diverged from the actual cod

[PATCH] D69996: [clangd] Fixes colon escaping on Windows

hokein added a comment. I believe this patch fixes the issue, but we need to update the file `test/semantic-highlighting.test.ts`), the test "Colorizer groups decorations correctly" is diverged from the actual code, although it is still passed (both `string` and `vscode.Uri` have the `toString

[PATCH] D69996: [clangd] Fixes colon escaping on Windows

ilya-biryukov closed this revision. ilya-biryukov added a comment. Sorry for the delay, forgot to submit on Friday. Also updated `package-lock.json` before submitting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 ___

[PATCH] D69996: [clangd] Fixes colon escaping on Windows

lh123 added a comment. Thanks for your reminder, I have sent an email to apply for commit access, but I don't know how long it will take. > Should I land this patch for you? Yes, you can land this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.or

[PATCH] D69996: [clangd] Fixes colon escaping on Windows

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Should I land this patch for you? If you don't have commit access yet, you could consider applying to get one