[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfde11e9f23a3: [OPENMP50]Generalize handling of context matching/scoring. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69952/new/ htt

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69952/new/ https://reviews.llvm.org/D69952

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev updated this revision to Diff 228690. ABataev added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69952/new/ https://reviews.llvm.org/D69952 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev marked 2 inline comments as done. ABataev added a comment. In D69952#1739366 , @jdoerfert wrote: > I think we are almost there. > > Last remaining points: > > - Constructor (see below) > - enum naming scheme (see below) > - can we test this somehow

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

jdoerfert added a comment. I think we are almost there. Last remaining points: - Constructor (see below) - enum naming scheme (see below) - can we test this somehow? Comment at: clang/include/clang/Basic/OpenMPKinds.h:43 +/// Struct to store the context selectors info. +templ

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev updated this revision to Diff 228481. ABataev added a comment. Score is part of context data. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69952/new/ https://reviews.llvm.org/D69952 Files: clang/include/clang/Basic/Attr.td clang/inclu

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev marked 3 inline comments as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:43 +/// Struct to store the context selectors info. +template > +struct OpenMPCtxSelectorData { jdoerfert wrote: > ABataev wrote: > > jdoe

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:43 +/// Struct to store the context selectors info. +template > +struct OpenMPCtxSelectorData { ABataev wrote: > jdoerfert wrote: > > ABataev wrote: > > > jdoerfert wrote: > > >

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev updated this revision to Diff 228290. ABataev added a comment. Rebase + address some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69952/new/ https://reviews.llvm.org/D69952 Files: clang/include/clang/Basic/Attr.td clang/incl

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:56 + OpenMPContextSelectorKind Ctx, const U &Names) + : CtxSet(CtxSet), Ctx(Ctx), Names(Names.begin(), Names.end()) {}

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev marked 3 inline comments as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:43 +/// Struct to store the context selectors info. +template > +struct OpenMPCtxSelectorData { jdoerfert wrote: > ABataev wrote: > > jdoe

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3310 +VariadicUnsignedArgument<"CtxSelectorSets">, +VariadicUnsignedArgument<"CtxSelectors">, VariadicStringArgument<"ImplVendors"> ABataev wrote: > jdoerfert wrote: > > I

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev marked 6 inline comments as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3310 +VariadicUnsignedArgument<"CtxSelectorSets">, +VariadicUnsignedArgument<"CtxSelectors">, VariadicStringArgument<"ImplVendors">

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3310 +VariadicUnsignedArgument<"CtxSelectorSets">, +VariadicUnsignedArgument<"CtxSelectors">, VariadicStringArgument<"ImplVendors"> Is it possible to have a `VariadicObjec

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added a subscriber: guansong. Herald added a project: clang. Untie context matching/scoring from the attribute for declare variant directive to simplify future uses in other context-dependent directives. Repository: rG