[PATCH] D69928: [clangd] Set RetainCommentsFromSystemHeaders to true

2019-11-07 Thread Ilya Biryukov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG001968490049: [clangd] Set RetainCommentsFromSystemHeaders to true (authored by ilya-biryukov). Changed prior to commit: https://reviews.llvm.org/D69928?vs=228173&id=228186#toc Repository: rG LLVM Gi

[PATCH] D69928: [clangd] Set RetainCommentsFromSystemHeaders to true

2019-11-07 Thread liu hui via Phabricator via cfe-commits
lh123 added a comment. In D69928#1736569 , @ilya-biryukov wrote: > LGTM, thanks! > Do you need someone to land this? Yes, I can‘t commit it. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69928/new/ https

[PATCH] D69928: [clangd] Set RetainCommentsFromSystemHeaders to true

2019-11-07 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Do you need someone to land this? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69928/new/ https://reviews.llvm.org/D

[PATCH] D69928: [clangd] Set RetainCommentsFromSystemHeaders to true

2019-11-06 Thread liu hui via Phabricator via cfe-commits
lh123 created this revision. lh123 added reviewers: sammccall, ilya-biryukov. lh123 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. clangd should retain comments from system headers. fixes