[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

2019-11-06 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. MyDeveloperDay marked 2 inline comments as done. Closed by commit rG3ddac7e56363: [clang-format] [RELAND] Remove the dependency on frontend (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

2019-11-06 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:310 SourceManager Sources(*Diags, Files); FileID FileID = createInMemoryFile(AssumedFileName, Code.get(), Sources,

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

2019-11-06 Thread Nico Weber via Phabricator via cfe-commits
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! One comment (the stale pointer one) and a more general suggestion (potentially for a future change) below, else I think this is good to go. Comment at: clang/tools/c

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

2019-11-05 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. In D69854#1734222 , @merge_guards_bot wrote: > Build result: fail - 33803 tests passed, 1 failed and 462 were skipped. > > failed: LLVM.Object/macho-invalid.test > > Log files: console-log.txt >

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

2019-11-05 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: fail - 33803 tests passed, 1 failed and 462 were skipped. failed: LLVM.Object/macho-invalid.test Log files: console-log.txt , CMakeCache.txt

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

2019-11-05 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay created this revision. MyDeveloperDay added reviewers: thakis, vlad.tsyrklevich, klimek, mitchell-stellar. MyDeveloperDay added projects: clang-format, clang. Herald added a subscriber: mgorny. relanding D68969: [clang-format] Remove the dependency on frontend